Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): add FilesAnalyzed and PackageVerificationCode fields for SPDX #5533

Conversation

DmitriyLewen
Copy link
Contributor

Description

In SPDX 2.3 we can't use FilesAnalyzed == false for packages with Files - If false, the package shall not contain any files. - https://spdx.github.io/spdx-spec/v2.3/package-information/#781-description

So we need to use FilesAnalyzed == true and fill PackageVerificationCode field for these packages.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 8, 2023
pkg/sbom/spdx/marshal.go Outdated Show resolved Hide resolved
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 8, 2023 09:00
pkg/sbom/spdx/marshal.go Outdated Show resolved Hide resolved
pkg/sbom/spdx/marshal.go Outdated Show resolved Hide resolved
@knqyf263 knqyf263 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into aquasecurity:main with commit cb241a8 Nov 9, 2023
13 checks passed
@DmitriyLewen DmitriyLewen deleted the feat/fill-PackageVerificationCode-spdx branch November 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants