Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reintroduce output writer #5564

Merged
merged 1 commit into from
Nov 14, 2023
Merged

refactor: reintroduce output writer #5564

merged 1 commit into from
Nov 14, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

See #5560

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
refactor: add output writer
9adab94 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Nov 13, 2023
@knqyf263 knqyf263 marked this pull request as ready for review November 14, 2023 00:09
@knqyf263
Copy link
Collaborator Author

@Moniseeta @santhosh1729 Please take a look.

@Moniseeta
Copy link
Contributor

@knqyf263 PR LGTM.
Though we were not able to test E2E in trivy premium, because of another dependency on #5245
So, I think we can merge this PR for now. In case anything else is required later, we can take it up in future

@knqyf263 knqyf263 added this pull request to the merge queue Nov 14, 2023
Merged via the queue into aquasecurity:main with commit 950e431 Nov 14, 2023
12 checks passed
@knqyf263 knqyf263 deleted the support_writer branch November 14, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen-keinan chen-keinan chen-keinan approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce io.Writer support for output
3 participants
@knqyf263 @Moniseeta @chen-keinan