Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show a deprecation notice for --scanners config #5587

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

It shows a warning message to encourage users to migrate to --scanners misconfig.

$ trivy repo --scanners config .
2023-11-15T11:35:57.027+0900    WARN    '--scanner config' is deprecated. Use '--scanner misconfig' instead. See https://github.com/aquasecurity/trivy/discussions/5586 for the detail.
2023-11-15T11:35:57.036+0900    INFO    Misconfiguration scanning is enabled

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Nov 15, 2023
@knqyf263 knqyf263 changed the title chore: show a deprecation notice for '--scanners config' chore: show a deprecation notice for --scanners config Nov 15, 2023
@knqyf263 knqyf263 marked this pull request as ready for review November 15, 2023 02:40
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into aquasecurity:main with commit a389529 Nov 15, 2023
13 checks passed
@knqyf263 knqyf263 deleted the deprecation_notice branch November 15, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants