Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: k8s friendly error messages kbom non cluster scans #5594

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: k8s friendly error messages kbom non cluster scans #5594

merged 2 commits into from
Nov 16, 2023

Conversation

chen-keinan
Copy link
Contributor

@chen-keinan chen-keinan commented Nov 15, 2023 •
edited
Loading

Description

fix: k8s friendly error messages kbom non cluster scans

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

Usage:

 trivy k8s all --format cyclonedx
2023-11-15T14:43:48.113+0200	INFO	"k8s with --format cyclonedx" disable security scanning
2023-11-15T14:43:48.120+0200	FATAL	Error: KBOM with CycloneDX format is not supported for all namespace scans
trivy k8s --format cyclonedx  -n kube-system pods/coredns-558bd4d5db-h22jb
2023-11-15T14:46:02.809+0200	INFO	"k8s with --format cyclonedx" disable security scanning
2023-11-15T14:46:02.816+0200	FATAL	Error: KBOM with CycloneDX format is not supported for resource scans

@chen-keinan
fix: k8s friendly error messages kbom non cluster scans
a86ed26 
Signed-off-by: chenk <hen.keinan@gmail.com>
knqyf263
knqyf263 reviewed Nov 16, 2023
View reviewed changes
pkg/k8s/commands/run.go Outdated Show resolved Hide resolved
pkg/k8s/commands/run.go Outdated Show resolved Hide resolved
@chen-keinan
fix: k8s friendly error messages kbom non cluster scans
09ebca5 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan chen-keinan requested a review from knqyf263 November 16, 2023 06:21
@knqyf263 knqyf263 enabled auto-merge November 16, 2023 06:25
@knqyf263 knqyf263 added this pull request to the merge queue Nov 16, 2023
Merged via the queue into aquasecurity:main with commit 2145464 Nov 16, 2023
12 checks passed
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

friendly messages for kbom support
2 participants
@chen-keinan @knqyf263