Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.116.0 to v1.134.0 #5822

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

nikpivkin
Copy link
Contributor

Description

aws-sdk-go v1.23.0 contained a breaking change, so the ec2 package needs to be updated:

Please upgrade ALL of your dependencies under the github.com/aws/aws-sdk-go-v2 namespace to the latest tags from yesterday's release, that should resolve the issue. Please chime in with the results if you can.

I tested the aws command and didn't notice any problems with other services.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin requested a review from knqyf263 as a code owner December 25, 2023 12:28
@nikpivkin nikpivkin changed the title chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.11.6 to v.134.0 chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.11.6 to v1.134.0 Dec 26, 2023
@nikpivkin nikpivkin changed the title chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.11.6 to v1.134.0 chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.116.0 to v1.134.0 Dec 26, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Dec 26, 2023
Merged via the queue into aquasecurity:main with commit 4cdff0e Dec 26, 2023
14 checks passed
@nikpivkin nikpivkin deleted the aws-ec2 branch December 27, 2023 12:28
@tburow
Copy link

tburow commented Jan 4, 2024

this needs to be released at least as a patch asap - current release version is broken

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 5, 2024

@tburow
Copy link

tburow commented Jan 5, 2024

done https://github.com/aquasecurity/trivy/releases/tag/v0.48.2

Does not appear to be fixed

`amazon-ebs.base-ami-build: https://github.com/aquasecurity/trivy/releases/download/v0.48.2/trivy_0.48.2_Linux-64bit.tar.gz
.
.
.

  • trivy vm --format json --output vulnReport.json --scanners vuln ami:ami-
    2024-01-05T16:26:11.613Z INFO Need to update DB
    2024-01-05T16:26:11.613Z INFO DB Repository: ghcr.io/aquasecurity/trivy-db
    2024-01-05T16:26:11.613Z INFO Downloading DB...
    600.74 KiB / 42.09 MiB [>] 1.39% ? p/s ?7.99 MiB / 42.09 MiB [----------->] 18.99% ? p/s ?19.81 MiB / 42.09 MiB [---------------------------->___________] 47.06% ? p/s ?31.62 MiB / 42.09 MiB [------------------------------------>] 75.14% 51.73 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 51.73 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 51.73 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 49.52 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 49.52 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 49.52 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 46.32 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 46.32 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 46.32 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [---------------------------------------------->] 100.00% 43.34 MiB p/s ETA 0s42.09 MiB / 42.09 MiB [-------------------------------------------------] 100.00% 17.32 MiB p/s 2.6s2024-01-05T16:26:15.268Z INFO Vulnerability scanning is enabled
    2024-01-05T16:26:17.034Z INFO Snapshot snap- found
    2024-01-05T16:26:17.034Z FATAL vm scan error: scan error: scan failed: failed analysis: EBS open error: EBS error: not found, ResolveEndpointV2`

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 6, 2024

@masahiro331 Any ideas?

@AshishSujgure
Copy link

Its not fixed yet:

trivy vm --aws-region us-east-1 --scanners vuln -s CRITICAL --format table --output vulnReport.txt ami:$ami
2024-01-09T12:39:01.886+0530    INFO    Need to update DB
2024-01-09T12:39:01.886+0530    INFO    DB Repository: ghcr.io/aquasecurity/trivy-db
2024-01-09T12:39:01.886+0530    INFO    Downloading DB...
42.13 MiB / 42.13 MiB [------------------------------------------------------------------------------------] 100.00% 3.18 MiB p/s 13s
2024-01-09T12:39:16.767+0530    INFO    Vulnerability scanning is enabled
2024-01-09T12:39:17.652+0530    INFO    Snapshot snap-09xxxxxxxxb74f found
2024-01-09T12:39:17.676+0530    FATAL   vm scan error: scan error: scan failed: failed analysis: EBS open error: EBS error: not found, ResolveEndpointV2

@tburow tburow mentioned this pull request Jan 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot scan AMI on AWS with v0.4.8.1
4 participants