Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add_scan2html_to_trivy_ecosystem #5875

Merged

Conversation

fatihtokus
Copy link
Contributor

Description

I have created this as per our discussion with @knqyf263 and @DmitriyLewen on #5388

@fatihtokus fatihtokus requested a review from knqyf263 as a code owner January 4, 2024 17:52
@fatihtokus fatihtokus changed the title add_scan2html_to_trivy_ecosystem docs: add_scan2html_to_trivy_ecosystem Jan 4, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 5, 2024

@itaysk Do you think it should be located under "Security Management"? I didn't find a good place. Should we create a new category?

@itaysk
Copy link
Contributor

itaysk commented Jan 7, 2024

I thought about it a still don't have a good idea. My best suggestion would to rename "security management" to "miscellaneous" and add this PR to the page. when the misc list grows big enough we can split it based on the entries that we see there.

@fatihtokus
Copy link
Contributor Author

I have applied @itaysk 's suggestion, please review @knqyf263.

@knqyf263 knqyf263 added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@knqyf263 knqyf263 added this pull request to the merge queue Jan 8, 2024
Merged via the queue into aquasecurity:main with commit 47b6c28 Jan 8, 2024
7 checks passed
@AnaisUrlichs
Copy link
Contributor

What about renaming "Security Management" into "Report Management" or just "Reporting", same as the section on output formats in the docs: https://aquasecurity.github.io/trivy/v0.48/docs/configuration/reporting/
Thoughts?

@AnaisUrlichs
Copy link
Contributor

We also need to update the new file name here:

- Security Management: ecosystem/security.md

@fatihtokus
Copy link
Contributor Author

We also need to update the new file name here:

- Security Management: ecosystem/security.md

I like the suggestion of 'Reporting' and I am happy to update mkdocs.yml as well. Wdyt guys, @itaysk , @knqyf263 ?

@knqyf263
Copy link
Collaborator

I don't have a strong opinion on the category. I'd defer to @itaysk.

@itaysk
Copy link
Contributor

itaysk commented Jan 14, 2024

sounds good to me :)

@fatihtokus
Copy link
Contributor Author

Created the new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants