Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about Bun #6001

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

nikpivkin
Copy link
Contributor

Description

Users have questions about Bun support, so I've added a note to the documentation.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review January 25, 2024 08:24
@nikpivkin nikpivkin requested a review from knqyf263 as a code owner January 25, 2024 08:24
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the tables as well.

@nikpivkin nikpivkin requested a review from knqyf263 January 26, 2024 10:33
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 added this pull request to the merge queue Jan 26, 2024
Merged via the queue into aquasecurity:main with commit 4df9363 Jan 26, 2024
7 checks passed
@itaysk
Copy link
Contributor

itaysk commented Jan 27, 2024

needs to be added here and here
N.B not sure why we need 3 places but for now at least keep it consistent

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 29, 2024

needs to be added here and here

We don't need to update this page as it doesn't mention package managers, but language.

And this page is exactly what we updated in this PR. Am I missing something? Note that this change has not been deployed yet and exists only in dev. @itaysk
https://aquasecurity.github.io/trivy/dev/docs/coverage/language/nodejs/

@knqyf263
Copy link
Collaborator

N.B not sure why we need 3 places but for now at least keep it consistent

Therefore, we have two places. One place is for an overview, and the other is for details.

@nikpivkin nikpivkin deleted the docs/bun-yarn-lock branch January 29, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants