-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report): support for filtering licenses and secrets via rego policy files #6004
feat(report): support for filtering licenses and secrets via rego policy files #6004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kristyko
Thanks for your work!
LGTM.
I left a few comments.
Please also update docs.
Also i think you can add examples for secret and license to basic.rego example file.
Regards, Dmitriy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left 1 small comment to avoid confusion.
About error in PR title:
We don't currently support multiple scopes.
So I think feat(report): support for filtering licenses and secrets via rego policy files
will be sufficient.
0d777f1
to
c6d8461
Compare
^ just rebased on the main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot!
LGTM.
@knqyf263 I approved this PR. Take a look, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Description
Support filtering licenses and secrets through rego policy files
Related issues
Discussion: #5730
Checklist