Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add governance #6090

Merged
merged 2 commits into from
Feb 12, 2024
Merged

docs: add governance #6090

merged 2 commits into from
Feb 12, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Feb 9, 2024

Description

Define core principles.

Issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into aquasecurity:main with commit b26f217 Feb 12, 2024
8 checks passed
@knqyf263 knqyf263 deleted the governance branch February 12, 2024 12:15
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks. Two small things:

  1. I think the title "governance" isn't the best word for this content. Governance (especially in open source) talks more about the team, the ceremony, the decision making framework. I don't have a great suggestion but perhaps "Principles" is more appropriate here.
  2. Consider adding a note about the relationship to Aqua commercial product, with reference to https://github.com/aquasecurity/resources/blob/main/trivy-aqua.md. meaning if something is in aqua territory is automatically out of scope for trivy.

@knqyf263
Copy link
Collaborator Author

I think the title "governance" isn't the best word for this content.

Yes, I was adding more content about how to make decisions or something like that. But I deleted them and focused on principles in this PR. I'll update it.

Consider adding a note about the relationship to Aqua commercial product, with reference to https://github.com/aquasecurity/resources/blob/main/trivy-aqua.md. meaning if something is in aqua territory is automatically out of scope for trivy.

OK.

@knqyf263
Copy link
Collaborator Author

updated
#6107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Governance Model for Trivy Project
5 participants