-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): Merge defsec into trivy #6109
Conversation
Signed-off-by: Simar <simar@linux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd/iac/allowed_actions/main.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for? I'd like to keep Trivy only under the cmd/
dir. Does Mage help?
https://github.com/aquasecurity/trivy/tree/main/magefiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I apologize for another big PR but it is the last remaining pieces of defsec that are part of this PR. As for the differences, we merged all the parsers (code that parses language files) and adapters (code that adapts parsed language files into defsec state) in the last PR. This PR is about merging the providers (code that describes the state of a service like AWS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I apologize for another big PR but it is the last remaining pieces of defsec that are part of this PR.
No apologies! I was just wondering why this PR was so large.
As for the differences, we merged all the parsers (code that parses language files) and adapters (code that adapts parsed language files into defsec state) in the last PR. This PR is about merging the providers (code that describes the state of a service like AWS).
I drew a diagram. Is this correct?
Yes I would say so 👍🏼 |
Thanks for confirming! |
Description
Merges any remaining defsec packages into Trivy.
Related issues
trivy-iac
into Trivy #5626 (comment)Related PRs
Checklist