Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): ensure consistent path handling across OS #6161

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

Trivy creates a virtual filesystem for post-analysers, so path handling should not depend on the OS.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review February 19, 2024 18:07
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@knqyf263
Copy link
Collaborator

@simar7 You can merge PRs if the change is only in pkg/iac or other IaC dirs, like you guys did in defsec/trivy-iac. If PR includes changes in other areas, it would be appreciated if you would wait for my review.

@simar7
Copy link
Member

simar7 commented Feb 21, 2024

@simar7 You can merge PRs if the change is only in pkg/iac or other IaC dirs, like you guys did in defsec/trivy-iac. If PR includes changes in other areas, it would be appreciated if you would wait for my review.

sounds good!

@simar7 simar7 added this pull request to the merge queue Feb 21, 2024
Merged via the queue into aquasecurity:main with commit 327cf88 Feb 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants