-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info log message about dev deps suppression #6211
feat: add info log message about dev deps suppression #6211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if showing the log message here? The downside is it is performed on the server side in client/server mode.
trivy/pkg/scanner/local/scan.go
Lines 422 to 432 in e1ea02c
// excludeDevDeps removes development dependencies from the list of applications | |
func excludeDevDeps(apps []ftypes.Application, include bool) { | |
if include { | |
return | |
} | |
for i := range apps { | |
apps[i].Libraries = lo.Filter(apps[i].Libraries, func(lib ftypes.Package, index int) bool { | |
return !lib.Dev | |
}) | |
} | |
} |
This is not good. I think that users rarely check server logs. In this case, they can easily miss this information. |
But after some thought i realized that your solution looks better because in my solution we will show this message even if the I will update PR. |
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
Description
By default, we suppress
Dev
dependencies (npm, yarn is currently support only).We need to show info about it.
Checklist