Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): don't ignore runtime scope for pom.xml files #6223

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix(java): don't ignore runtime scope for pom.xml files #6223

merged 3 commits into from
Mar 4, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

We don't need to ignore runtime scope for pom.xml files.
See more in #6207

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Feb 28, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 28, 2024 11:04
knqyf263
knqyf263 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This claim sounds reasonable to me, but I'm not 100% sure. Let's see how the community reacts.

@knqyf263 knqyf263 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into aquasecurity:main with commit c4b5ab7 Mar 4, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-pom/dont-skip-runtime-scope branch March 5, 2024 03:50
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(pom): don't ignore runtime scope
2 participants
@DmitriyLewen @knqyf263