fix(nodejs): add name validation for package name from package.json
#6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Mar 8, 2024
| @@ -40,6 +43,10 @@ func (p *Parser) Parse(r io.Reader) (Package, error) { | |||
| return Package{}, xerrors.Errorf("JSON decode error: %w", err) | |||
| } | |||
|
|
|||
| if !IsValidName(pkgJSON.Name) { | |||
| return Package{}, xerrors.Errorf("Name can only contain URL-friendly characters") | |||
There was a problem hiding this comment.
I think the warning message is enough. Otherwise, if a package.json file contains an invalid name for testing, it fails the whole scanning.
There was a problem hiding this comment.
Or is it anyway converted into a warning in analyzer.go? If so, never mind my comment.
There was a problem hiding this comment.
Or is it anyway converted into a warning in analyzer.go
Right.
knqyf263
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Npm uses some rules for package names - https://docs.npmjs.com/cli/v10/configuring-npm/package-json
We need to reproduce
npmlogic and return error for invalid package names.Related Discussions
Checklist