-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image): goversion as stdlib #6277
feat(image): goversion as stdlib #6277
Conversation
|
👋 it's been a little over a month - are you able to provide any feedback? Thanks! |
@thepwagner thanks for the contribution! some of the maintainers are away this week, we will try to look at it soon after returning. |
Thanks for your contribution. OSV uses
|
Hmm. But they also use
|
It seems like they use BTW, I don't know why the tests were not triggered. I'll merge the main branch and see if it triggers the tests. |
Head branch was pushed to by a user without write access
📝 Go versions prior to 1.21 did an unusual thing with their version numbers. It probably won't matter now that those all have patches and 1.20 is not supported.
|
Trivy expects semantic versions in Go. It may show warnings with binaries compiled Go prior to 1.21, but I believe it won't stop scanning. Let's see. |
Co-authored-by: knqyf263 <knqyf263@gmail.com>
Description
Modify the
golang/binary
parser to emit the version of the golang runtime asstdlib
.The
purl
generated by this name is compatible to what is produced bysyft
, but I don't think it will be useful for vulnerability matching. Grype's strategy seems to be CPE matching.My goal is to make the go runtime version visible when reporting in the CycloneDX format. This is motivated by 2024-03-05 release: https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg
Related issues
Checklist