Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): convert severity for custom rules #6500

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Apr 16, 2024

Description

By default we filter all secrets by severity.
However, there may be cases where user uses wrong severity (wrong name or case (e.g. lower case)) for custom rules.
We need to convert these severity levels to upper case to avoid incorrect filtering.

example - #6454 (reply in thread)

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Apr 16, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review April 16, 2024 06:47
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner April 16, 2024 06:47
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any GitHub Issue for this fix? Or did you stumble upon this problem and quickly fix it?

@DmitriyLewen
Copy link
Contributor Author

DmitriyLewen commented Apr 16, 2024

I checked the user custom rules for #6454 and saw this issue - #6454 (reply in thread).

When I found reason for lost secrets, I quickly created this PR.

@knqyf263 knqyf263 added this pull request to the merge queue Apr 16, 2024
@knqyf263
Copy link
Collaborator

OK, thanks!

Merged via the queue into aquasecurity:main with commit 46d5aba Apr 16, 2024
13 checks passed
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants