Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use tmp dir inside Trivy repo dir for GoReleaser #6533

Merged
merged 2 commits into from
Apr 22, 2024
Merged

ci: use tmp dir inside Trivy repo dir for GoReleaser #6533

merged 2 commits into from
Apr 22, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

GoReleaser uses TMPDIR during operation.
But we moved all free space to Trivy directory and got error - https://github.com/aquasecurity/trivy/actions/runs/8781316705/job/24095365717#step:14:47

So we also need to move the GoReleaser temp directory to Trivy directory.

Test run - https://github.com/DmitriyLewen/trivy/actions/runs/8782979882/job/24098204231#step:14:78

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Apr 22, 2024
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner April 22, 2024 11:52
knqyf263
knqyf263 reviewed Apr 22, 2024
View reviewed changes
.github/workflows/reusable-release.yaml Outdated

- name: "remove gpg key"
run: |
rm gpg.key
rm gpg.key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: added spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't add them 😄
removed in f59d32a

@knqyf263 knqyf263 enabled auto-merge April 22, 2024 12:14
@knqyf263 knqyf263 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into aquasecurity:main with commit 30cc88f Apr 22, 2024
12 checks passed
knqyf263 pushed a commit that referenced this pull request Apr 22, 2024
@DmitriyLewen @knqyf263
ci: use tmp dir inside Trivy repo dir for GoReleaser (#6533)
9aa9e17
@DmitriyLewen DmitriyLewen deleted the ci/move-tmp-dir-to-trivy branch April 23, 2024 04:37
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@DmitriyLewen @fl0pp5
ci: use tmp dir inside Trivy repo dir for GoReleaser (aquasecurity#6533)
721653d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitriyLewen @knqyf263