Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vuln): skip empty versions #6542

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Apr 23, 2024

Description

It currently shows warnings on empty versions.

$ trivy sbom /tmp/sbom-k8s-cluster.json
2024-04-23T13:53:05+04:00       INFO    Vulnerability scanning is enabled
2024-04-23T13:53:05+04:00       INFO    Detected SBOM format    format="cyclonedx-json"
...
2024-04-23T13:53:05+04:00       INFO    [kubernetes] Detecting vulnerabilities...
2024-04-23T13:53:05+04:00       WARN    Version matching error  err="version error (): malformed version: "
2024-04-23T13:53:05+04:00       WARN    Version matching error  err="version error (): malformed version: "
2024-04-23T13:53:05+04:00       WARN    Version matching error  err="version error (): malformed version: "
2024-04-23T13:53:05+04:00       WARN    Version matching error  err="version error (): malformed version: "

This PR changed it to skip empty versions and show debug messages.

$ trivy sbom /tmp/sbom-k8s-cluster.json -d
...
2024-04-23T13:47:40+04:00       INFO    [kubernetes] Detecting vulnerabilities...
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Scanning packages from the file    file_path=""
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Skipping package without version   name="cilium"
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Skipping package without version   name="hubble-relay"
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Skipping package without version   name="hubble-ui"
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Skipping package without version   name="k8s.io/kube-proxy"
2024-04-23T13:47:40+04:00       DEBUG   [kubernetes] Skipping package without version   name="kube-dns"

Also it passes context to the scanner to make logger context-aware.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Apr 23, 2024
@knqyf263 knqyf263 marked this pull request as ready for review April 23, 2024 09:57
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner April 23, 2024 09:57
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left 1 comment

pkg/detector/library/detect.go Outdated Show resolved Hide resolved
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 enabled auto-merge April 24, 2024 05:54
@knqyf263 knqyf263 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into aquasecurity:main with commit 164b025 Apr 24, 2024
12 checks passed
@knqyf263 knqyf263 deleted the fix/skip_empty branch April 24, 2024 06:22
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants