Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): add main module #6574

Merged
merged 1 commit into from
Apr 27, 2024
Merged

feat(go): add main module #6574

merged 1 commit into from
Apr 27, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

Extract the main module from go.mod. As far as I know, it should not be possible to get the version, but it is programmatically possible to get it (Module.Mod has the version field), so I try to get it just in case.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
feat(gomod): add main module
4cbc526 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Apr 27, 2024
@knqyf263 knqyf263 changed the title feat(gomod): add main module feat(go): add main module Apr 27, 2024
@knqyf263 knqyf263 marked this pull request as ready for review April 27, 2024 09:38
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner April 27, 2024 09:38
DmitriyLewen
DmitriyLewen approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 enabled auto-merge April 27, 2024 09:43
@knqyf263 knqyf263 added this pull request to the merge queue Apr 27, 2024
Merged via the queue into aquasecurity:main with commit 2d090ef Apr 27, 2024
13 checks passed
@knqyf263 knqyf263 deleted the feat/gomod_main branch April 27, 2024 10:22
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@knqyf263 @fl0pp5
feat(go): add main module (aquasecurity#6574)
9af69b3 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen