fix(fs): handle default skip dirs properly #6628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two problems. First,
d.Info()
could return an error on system files, like/proc
. It is currently called before skipping dirs. File walking exits before processing skipping dirs. Second, user-specified skipping dirs are pre-processed, but the default skipping dirs are also processed by mistake. This PR fixes these two problems.Related issues
Checklist