-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misconf): Add support for --include-deprecated-checks
#6671
feat(misconf): Add support for --include-deprecated-checks
#6671
Conversation
github.com/aquasecurity/trivy-aws v0.8.0 | ||
github.com/aquasecurity/trivy-aws v0.8.1-0.20240511051125-4393910b056b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: update this when aquasecurity/trivy-aws#148 is merged
@nikpivkin we can merge this first once you review it as it stacks on top of #6664 |
pkg/iac/rego/scanner.go
Outdated
@@ -248,6 +253,12 @@ func (s *Scanner) ScanInput(ctx context.Context, inputs ...Input) (scan.Results, | |||
continue | |||
} | |||
|
|||
if !s.includeDeprecatedChecks { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditions can be combined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a small comment, but lgtm
Description
Adds support for
--include-deprecated-checks
. This is a stacked PR on #6664Related issues
--ignore-deprecated-checks
to ignore deprecated checks #6665Related PRs
Checklist