Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Add support for --include-deprecated-checks #6671

Merged
merged 3 commits into from
May 14, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 11, 2024

Description

Adds support for --include-deprecated-checks. This is a stacked PR on #6664

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this May 11, 2024
github.com/aquasecurity/trivy-aws v0.8.0
github.com/aquasecurity/trivy-aws v0.8.1-0.20240511051125-4393910b056b
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: update this when aquasecurity/trivy-aws#148 is merged

@simar7 simar7 marked this pull request as ready for review May 11, 2024 05:21
@simar7 simar7 requested review from nikpivkin and knqyf263 as code owners May 11, 2024 05:21
@simar7
Copy link
Member Author

simar7 commented May 11, 2024

@nikpivkin we can merge this first once you review it as it stacks on top of #6664

@@ -248,6 +253,12 @@ func (s *Scanner) ScanInput(ctx context.Context, inputs ...Input) (scan.Results,
continue
}

if !s.includeDeprecatedChecks {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditions can be combined

Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small comment, but lgtm

@simar7 simar7 merged commit 490ddd3 into add-check-deprecation-support May 14, 2024
17 checks passed
@simar7 simar7 deleted the include-deprecated-checks branch May 14, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants