Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Support --skip-* for all included modules #7579

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 24, 2024

Description

Add support for skip-dirs and skip-files in misconfig scanning at the parsing stage. This allows us to filter out un-needed files prior to scanning rather than post scanning, thereby reducing scanning time and memory.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 marked this pull request as ready for review September 24, 2024 05:53
@simar7 simar7 changed the title feat(misconf): Support --skip-* for all included modules feat(misconf): Support --skip-* for all included modules Sep 24, 2024
@nikpivkin
Copy link
Contributor

@simar7 Why not move the responsibility for skipping files and directories to the virtual file system, as suggested here? Then this would be the only place responsible for file skipping for all scanners.

@simar7
Copy link
Member Author

simar7 commented Sep 27, 2024

@simar7 Why not move the responsibility for skipping files and directories to the virtual file system, as suggested here? Then this would be the only place responsible for file skipping for all scanners.

I looked into it but since we already parse individual files within the parser, I found it easier to just do it there. Also at the parser level the file paths are rooted at the scan target. Keeping it as option on each parser can also help us change each parser's behavior for skip files.

But if you think otherwise, feel free to push your changes to this branch.

@simar7 simar7 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into aquasecurity:main with commit c0e8da3 Oct 2, 2024
12 checks passed
@simar7 simar7 deleted the fix-7220-2 branch October 2, 2024 05:41
@aqua-bot aqua-bot mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(misconf): directory filtering after scanning
2 participants