Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): properly handle multiple archived dependencies #7782

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(helm): properly handle multiple archived dependencies #7782

merged 2 commits into from
Oct 29, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Oct 23, 2024 •
edited
Loading

Description

If the archive is a dependency (located in the charts directory), we don't have to unpack it manually, as the Helm package will take care of that.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
fix(helm): properly handle multiple archived dependencies
d62f35e 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review October 24, 2024 09:33
@nikpivkin nikpivkin requested a review from simar7 as a code owner October 24, 2024 09:33
prezha
prezha reviewed Oct 25, 2024
View reviewed changes
Copy link

@prezha prezha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikpivkin thanks for the pr!

i left some comments with example of a case where i think we could improve the handling and avoid the issue

pkg/iac/scanners/helm/parser/parser.go Outdated Show resolved Hide resolved
pkg/iac/scanners/helm/parser/parser.go Show resolved Hide resolved
@nikpivkin
handle non-deps archives
f105377 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@simar7 simar7 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into aquasecurity:main with commit 6fab88d Oct 29, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Oct 29, 2024
Merged
@prezha prezha mentioned this pull request Nov 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prezha prezha prezha left review comments

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(helm): properly handle multiple archived dependencies
3 participants
@nikpivkin @simar7 @prezha