Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secret): optimize performance by moving ToLower operation outside loop #7862

Merged

Conversation

Yeatesss
Copy link
Contributor

@Yeatesss Yeatesss commented Nov 4, 2024

Description

This PR optimizes the performance of the keyword matching function by eliminating redundant ToLower operations inside the loop. Previously, content was being converted to lowercase in every loop iteration, which was inefficient. The change moves this operation outside the loop and stores the result in a variable for reuse.

Before:

for _, kw := range r.Keywords {
    if bytes.Contains(bytes.ToLower(content), []byte(strings.ToLower(kw))) {
        return true
    }
}

After

contentLower = bytes.ToLower(content)
for _, kw := range r.Keywords {
    if bytes.Contains(contentLower, []byte(strings.ToLower(kw))) {
        return true
    }
}

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

@afdesk afdesk changed the title refactor:optimize performance by moving ToLower operation outside loop refactor(secret):optimize performance by moving ToLower operation outside loop Nov 4, 2024
@afdesk afdesk changed the title refactor(secret):optimize performance by moving ToLower operation outside loop refactor(secret): optimize performance by moving ToLower operation outside loop Nov 4, 2024
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yeatesss Thanks!

LGTM

cc. @knqyf263

@knqyf263 knqyf263 added this pull request to the merge queue Nov 5, 2024
Merged via the queue into aquasecurity:main with commit 2529b58 Nov 5, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants