Include target value in Sarif template ruleID #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #991 +/- ##
==========================================
- Coverage 68.50% 62.18% -6.33%
==========================================
Files 57 65 +8
Lines 2210 2626 +416
==========================================
+ Hits 1514 1633 +119
- Misses 564 858 +294
- Partials 132 135 +3
Continue to review full report at Codecov.
|
knqyf263
reviewed
May 13, 2021
contrib/sarif.tpl
Outdated
| @@ -20,7 +20,7 @@ | |||
| , | |||
| {{- end }} | |||
| { | |||
| "id": "{{ .VulnerabilityID }}/{{ .PkgName }}/{{ .InstalledVersion }}", | |||
| "id": "{{ .VulnerabilityID }}/{{ escapeString (toPathUri $result.Target) }}/{{ .PkgName }}/{{ .InstalledVersion }}", | |||
There was a problem hiding this comment.
I recommend using toJson from sprig.
Suggested change
| "id": "{{ .VulnerabilityID }}/{{ escapeString (toPathUri $result.Target) }}/{{ .PkgName }}/{{ .InstalledVersion }}", | |
| "id": {{ printf "%s: %s-%s %s" $result.Target .PkgName .InstalledVersion .VulnerabilityID | toJson }}, |
knqyf263
approved these changes
May 13, 2021
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Include target value in Sarif template ruleID * Fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.