use execl() instead of system() as possible fix for #52 #56
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additional processes
avcbvamorec
added a commit
to avcbvamorec/incron
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm also afflicted with #52. The problem only occurs with system incronjobs, while user incrontabs are not affected.
In
UserTable::OnEvent(…)these type of incronjobs are handled differently. Incrondfork()s and handles the logic in the child process. User incrontabs are invoked by jumping toUserTable::RunAsUser(…)which runs the specified command byexeclp()ing, replacing the child process. System incrontabs' commands are run usingsystem()which is basically anotherfork()and anexecl()– leading to another child process and keeping the first child alive.By replacing
system()withexecl()the first child should be replaced by the desired command and no additional incrond-processes should show up.Please correct me if I'm wrong.