chore(tests): update ANT test to only deploy once, install husky, setup initial unit tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests take a while to set up, to so avoid deploying multiple ANTs, we deploy one and use it throughout each test.
dtfiedler
changed the title
dtfiedler
commented
Dec 11, 2023
Comment on lines
-120
to
-127
| it.each([ | ||
| { | ||
| transactionId: 'NEWnqsybd98-DRk6F6wdbBSkTouUShmnIA-pW4N-Hzs', // too short | ||
| ttlSeconds: -MIN_TTL_LENGTH, | ||
| }, | ||
| { | ||
| transactionId: 'bad record', // too short | ||
| ttlSeconds: MIN_TTL_LENGTH, |
There was a problem hiding this comment.
we will move these to unit tests
dtfiedler
commented
Dec 11, 2023
tests/setRecord.test.ts
Outdated
Comment on lines
202
to
216
| it.each([ | ||
| { | ||
| subDomain: '@', | ||
| transactionId: 'CTRLqsybd98-DRk6F6wdbBSkTouUShmnIA-pW4N-Hzs', | ||
| expect(state.records[subDomain]).toEqual({ | ||
| transactionId: antContractOwnerAddress, | ||
| ttlSeconds: MIN_TTL_LENGTH, | ||
| }, | ||
| { | ||
| subDomain: 'same_as_root', | ||
| transactionId: 'CTRLqsybd98-DRk6F6wdbBSkTouUShmnIA-pW4N-Hzs', | ||
| ttlSeconds: MIN_TTL_LENGTH, | ||
| }, | ||
| { | ||
| subDomain: 'remove_this', | ||
| ttlSeconds: MIN_TTL_LENGTH * 2, | ||
| transactionId: 'CTRLajVdPOhf3fCFDbrRuZXVRhhgNOJjbmgp8kjl2Jc', |
dtfiedler
commented
Dec 11, 2023
Comment on lines
-31
to
-35
| global.arlocal = arlocal; | ||
| global.arweave = arweave; | ||
| global.wallets = wallets; | ||
| global.contractIds = contractIds; | ||
| global.warp = warp; |
There was a problem hiding this comment.
this does not work as you think it does @atticusofsparta
dtfiedler
commented
Dec 11, 2023
dtfiedler
commented
Dec 11, 2023
Comment on lines
-30
to
-33
| const ANT = await ANTDeployer(warp, { | ||
| address: defaultOwner[0], | ||
| wallet: defaultOwner[1], | ||
| }); |
There was a problem hiding this comment.
deploying an ANT for every test increases total testing time, so we now only deploy once
added 4 commits
December 11, 2023 07:40
dtfiedler
changed the title
dtfiedler
commented
Dec 11, 2023
| beforeEach(async () => { | ||
| const { wallet, address } = await getLocalWallet(arweave); | ||
| // deploy a separate contract for this test | ||
| const { contractTxId } = await deployANTContract({ |
There was a problem hiding this comment.
since we cannot guarantee order of execution - and the result of this test will impact our ability to run other calls on the existing ANT contract - we deploy a separate one. this adds overhead - but prevents inconsistent testing results.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
dtfiedler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests take a while to set up, to so avoid deploying multiple ANTs, we deploy one and use it throughout each test.