Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PE-6326): add ci cd for publish workflow #19

Merged
merged 13 commits into from
Oct 10, 2024

Conversation

atticusofsparta
Copy link
Contributor

No description provided.

@atticusofsparta atticusofsparta force-pushed the PE-6326-automate-ant-process-publishing branch from a6a3331 to 3df8eb6 Compare October 8, 2024 16:49
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
@atticusofsparta atticusofsparta changed the base branch from main to develop October 8, 2024 22:49
@atticusofsparta atticusofsparta force-pushed the PE-6326-automate-ant-process-publishing branch from d05c8af to 82232dd Compare October 8, 2024 22:51
@atticusofsparta atticusofsparta force-pushed the PE-6326-automate-ant-process-publishing branch from 01d8a9f to 91052a8 Compare October 8, 2024 23:02
CHANGELOG.md Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
tools/publish-aos.js Outdated Show resolved Hide resolved
Comment on lines 22 to 33
let wallet = process.env.WALLET;
if (!wallet) {
try {
wallet = fs.readFileSync(path.join(__dirname, 'key.json'), 'utf-8');
} catch (error) {
console.error(
'No key found, please set WALLET environment variable or provide a key.json file',
);
return;
}
}
const jwk = JSON.parse(wallet);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh, you can just blow up if we don't have a wallet

Suggested change
let wallet = process.env.WALLET;
if (!wallet) {
try {
wallet = fs.readFileSync(path.join(__dirname, 'key.json'), 'utf-8');
} catch (error) {
console.error(
'No key found, please set WALLET environment variable or provide a key.json file',
);
return;
}
}
const jwk = JSON.parse(wallet);
const jwk = process.env.WALLET ? JSON.parse(process.env.WALLET) : fs.readFileSync(path.join(__dirname, process.env.WALLET_PATH || 'key.json', 'utf-8');

Copy link
Collaborator

@dtfiedler dtfiedler Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just returning here will exit with code 0 - which means we won't throw and ultimately not send a failure message in slack. hence why i suggested we just throw up on an invalid wallet. please add the suggestion.

cc @atticusofsparta

version.js Outdated Show resolved Hide resolved
@dtfiedler dtfiedler self-requested a review October 10, 2024 16:10
const turbo = TurboFactory.authenticated({ signer });

const publishingTags = Object.entries({
'App-Name': 'aos-LUA',
Copy link
Collaborator

@dtfiedler dtfiedler Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jc - why aos-LUA? why not AR-IO-ANT-Deploy or something useful for this deploy script that is actually creating the data item?


const publishingTags = Object.entries({
'App-Name': 'aos-LUA',
'App-Version': version,
Copy link
Collaborator

@dtfiedler dtfiedler Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this be the version of the build tool creating the data item?

we can add something like AR-IO-ANT-Release-Version to include the specific version

@dtfiedler dtfiedler self-requested a review October 10, 2024 16:20
Copy link
Collaborator

@dtfiedler dtfiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@atticusofsparta atticusofsparta merged commit 151f6e2 into develop Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants