-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(PE-6326): add ci cd for publish workflow #19
chore(PE-6326): add ci cd for publish workflow #19
Conversation
a6a3331
to
3df8eb6
Compare
d05c8af
to
82232dd
Compare
01d8a9f
to
91052a8
Compare
…ource code, removed commented out code
tools/publish-aos.js
Outdated
let wallet = process.env.WALLET; | ||
if (!wallet) { | ||
try { | ||
wallet = fs.readFileSync(path.join(__dirname, 'key.json'), 'utf-8'); | ||
} catch (error) { | ||
console.error( | ||
'No key found, please set WALLET environment variable or provide a key.json file', | ||
); | ||
return; | ||
} | ||
} | ||
const jwk = JSON.parse(wallet); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh, you can just blow up if we don't have a wallet
let wallet = process.env.WALLET; | |
if (!wallet) { | |
try { | |
wallet = fs.readFileSync(path.join(__dirname, 'key.json'), 'utf-8'); | |
} catch (error) { | |
console.error( | |
'No key found, please set WALLET environment variable or provide a key.json file', | |
); | |
return; | |
} | |
} | |
const jwk = JSON.parse(wallet); | |
const jwk = process.env.WALLET ? JSON.parse(process.env.WALLET) : fs.readFileSync(path.join(__dirname, process.env.WALLET_PATH || 'key.json', 'utf-8'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just returning here will exit with code 0 - which means we won't throw and ultimately not send a failure message in slack. hence why i suggested we just throw up on an invalid wallet. please add the suggestion.
tools/publish-aos.js
Outdated
const turbo = TurboFactory.authenticated({ signer }); | ||
|
||
const publishingTags = Object.entries({ | ||
'App-Name': 'aos-LUA', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jc - why aos-LUA
? why not AR-IO-ANT-Deploy
or something useful for this deploy script that is actually creating the data item?
tools/publish-aos.js
Outdated
|
||
const publishingTags = Object.entries({ | ||
'App-Name': 'aos-LUA', | ||
'App-Version': version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be the version of the build tool creating the data item?
we can add something like AR-IO-ANT-Release-Version
to include the specific version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
… and refine publish script
chore(ci): update all scripts to be mjs, replace require with imports…
No description provided.