fix(PE-7344): update handlers to integrate with token spec #59
+283
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticusofsparta
force-pushed
the
PE-7344-update-token-spec
branch
from
fb07989 to
0d96d3a
Compare
atticusofsparta
commented
Jan 15, 2025
src/common/main.lua
Outdated
| Balance = tostring(balRes), | ||
| Ticker = Ticker, | ||
| Account = addressToCheck, | ||
| Address = addressToCheck, |
There was a problem hiding this comment.
left in for backwards compatibility
atticusofsparta
commented
Jan 15, 2025
| assert.strictEqual(typeof balanceData, 'string'); | ||
| assert.strictEqual(typeof balanceTag, 'string'); | ||
| assert.strictEqual(balanceData, balanceTag); | ||
| assert.strictEqual(Number.isInteger(parseInt(balanceData)), true); |
There was a problem hiding this comment.
Specific to ANTs - in the case of other tokens these would need to be modified to bint checking
atticusofsparta
commented
Jan 15, 2025
| )?.value; | ||
| assert(errorRef, 'Error notice is not a reply message'); | ||
| const errorTag = errorMessage.Tags.find((t) => t.name === 'Error'); | ||
| assert.strictEqual(errorTag.value, 'Insufficient Balance!'); |
There was a problem hiding this comment.
Since this is mainly for integration with other platforms i wasn't certain on how granular to go here, so decided on exact error messages being enforced.
dtfiedler
reviewed
Jan 23, 2025
src/common/main.lua
Outdated
Comment on lines
92
to
104
| if msg.reply then | ||
| msg.reply({ | ||
| Action = "Transfer-Error", | ||
| ["Message-Id"] = msg.Id, | ||
| Error = "Insufficient Balance!", | ||
| }) | ||
| else | ||
| ao.send({ | ||
| Target = msg.From, | ||
| Action = "Transfer-Error", | ||
| ["Message-Id"] = msg.Id, | ||
| Error = "Insufficient Balance!", | ||
| }) |
There was a problem hiding this comment.
nit - wrap these in a Send util like so https://github.com/ar-io/ar-io-network-process/blob/develop/src/main.lua#L128-L135
There was a problem hiding this comment.
makes sense 79bd001
dtfiedler
requested changes
Jan 23, 2025
dtfiedler
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates handlers to match responses on like handlers from https://github.com/permaweb/aos/blob/main/blueprints/token.lua
Adds a new test specifically for this spec, apart from our existing balances test