feat(PE-7068): reassign name #624

atticusofsparta · 2024-12-13T16:36:18Z

No description provided.

github-actions · 2024-12-13T16:59:49Z

Visit the preview URL for this PR (updated for commit 92fc632):

https://arns-portal--pr624-pe-7068-reassign-nam-304byfoo.web.app

_{(expires Wed, 01 Jan 2025 19:33:12 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1f59769442cb89cf2a92042a342e51fe94047b94}

fedellen · 2024-12-13T18:25:39Z

src/components/modals/ant-management/ReassignNameModal/ReassignNameModal.tsx

+    }
+  }
+
+  if (!show) return <></>;


nit: could have this at the top of the component to prevent the above code from running

Hooks need to be mounted deterministically

That being said, because this uses the useDomainInfo hook, it shouldnt be doing anything extra here, since it is being access from a page that is also using that hook - internally it uses useQuery which will dedupe the request and return the same data to all the components calling it.

fedellen · 2024-12-13T18:27:40Z

src/components/modals/ant-management/ReassignNameModal/ReassignNameModal.tsx

+            <button
+              className="bg-primary-thin p-3 rounded"
+              onClick={() => setWorkflow(REASSIGN_NAME_WORKFLOWS.NEW_EXISTING)}
+            >
+              Create new ANT
+            </button>
+            <button
+              className="bg-primary-thin p-3 rounded"
+              onClick={() => setWorkflow(REASSIGN_NAME_WORKFLOWS.EXISTING)}
+            >
+              Use existing ANT
+            </button>


nit: common <button>s could share a component to share css styling

fedellen · 2024-12-13T18:30:04Z

src/components/modals/ant-management/ReassignNameModal/ReassignNameModal.tsx

+      <div className="modal-container">
+        <div className="flex flex-col rounded-md border border-dark-grey bg-foreground p-6 w-[32rem] gap-8 text-white">
+          <div className="flex flex-row justify-between items-center">
+            <h2 className="text-[24px]">Name Reassignment</h2>


does text-[24px] become responsive by override elsewhere? I would expect a callout to a text variable that handles different screen widths

especially since they're hard coded throughout. getting each view right for each screen widths would prove more challenging without some shared responsiveness in the app

not necessary to do any of this in this PR's context, just calling out some maintainability nits

Good point, i should be using rem here

fedellen · 2024-12-13T18:36:03Z

src/components/modals/ant-management/ReassignNameModal/ReassignNameModal.tsx

+                      'size-[25px] cursor-pointer rounded-full border border-white shadow-[0_2px_10px] shadow-black outline-none hover:bg-white focus:shadow-[0_0_0_2px] focus:shadow-black transition-all',
+                  },
+                  {
+                    label: (
+                      <label
+                        htmlFor="r1"
+                        className={`pl-[15px] text-[15px] leading-none ${
+                          workflow === REASSIGN_NAME_WORKFLOWS.NEW_BLANK
+                            ? 'text-white'
+                            : 'text-grey'
+                        } whitespace-nowrap cursor-pointer hover:text-white`}
+                      >
+                        Use blank slate
+                      </label>
+                    ),
+                    value: REASSIGN_NAME_WORKFLOWS.NEW_BLANK,
+                    className:
+                      'size-[25px] cursor-pointer rounded-full border  border-white shadow-[0_2px_10px] shadow-black outline-none hover:bg-white focus:shadow-[0_0_0_2px] focus:shadow-black transition-all',
+                  },


nit: repeated styles, could share a simple var so that when we make changes to styles, we make them consistently

const radioGroupReassignNameStyles: string = `my-styles`

or go more fancy, depending on how widespread styles are repeated

const radioGroupReassignNameStyles: string = `${commonStyles} ${radioGroupStyles} ${reassignNameStyles}`

fedellen · 2024-12-13T18:40:56Z

src/state/actions/dispatchANTInteraction.ts

+        // for UX so the user sees the signing message
+        await sleep(2000);
+        result = await antProcess.reassignName({
+          name: payload.name,
+          arioProcessId: payload.arioProcessId,
+          antProcessId: newAntProcessId,
+        });
+        break;
+      }


could explain further on the comment here. Also, await spawnANT should not end until that message is already signed

ah, I get it -- its so the user can see the 'Reassigning ArNS name, please wait... ' + message

Exactly yeah - noticed the reassign was a bit quick sometimes and it didn't even give the message time to rerender.

fedellen

left a few nits and questions, looking good!

kunstmusik · 2024-12-16T16:29:08Z

src/components/pages/ManageDomain/ManageDomain.tsx

+                });
+              }}
+            >
+              <Star className={`w-[16px]`} />{' '}


fix(PE-7323): block reassign workflow if name is in grace period

atticusofsparta added 4 commits December 11, 2024 10:18

fix(reassign name): add reassign name workflow

e687706

fix(reassign name): add states to reassign name workflow

f2d0c27

fix(reassign): add review workflow

43eddb6

feat(reassign name): update reassign name workflow

a32e2e2

atticusofsparta requested a review from a team as a code owner December 13, 2024 16:36

atticusofsparta added 2 commits December 13, 2024 10:37

Merge remote-tracking branch 'origin/develop' into PE-7068-reassign-name

1b5b343

fix(ao): add ao client to dispatch api calls

2949948

atticusofsparta temporarily deployed to develop December 13, 2024 16:57 — with GitHub Actions Inactive

fedellen reviewed Dec 13, 2024

View reviewed changes

fedellen previously approved these changes Dec 13, 2024

View reviewed changes

atticusofsparta dismissed fedellen’s stale review via a3495ec December 13, 2024 20:05

atticusofsparta temporarily deployed to develop December 13, 2024 20:10 — with GitHub Actions Inactive

atticusofsparta force-pushed the PE-7068-reassign-name branch from a3495ec to 691bfc9 Compare December 13, 2024 21:06

atticusofsparta temporarily deployed to develop December 13, 2024 21:12 — with GitHub Actions Inactive

fix(domain settings): restrict only-only workflows

e9afb0e

atticusofsparta force-pushed the PE-7068-reassign-name branch from 691bfc9 to e9afb0e Compare December 13, 2024 22:45

atticusofsparta temporarily deployed to develop December 13, 2024 22:51 — with GitHub Actions Inactive

kunstmusik reviewed Dec 16, 2024

View reviewed changes

src/components/pages/ManageDomain/ManageDomain.tsx

});

}}

>

<Star className={`w-[16px]`} />{' '}

Copy link

Contributor

kunstmusik Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use rem

kunstmusik previously approved these changes Dec 16, 2024

View reviewed changes

Merge remote-tracking branch 'origin/develop' into PE-7068-reassign-name

bb841b4

atticusofsparta dismissed kunstmusik’s stale review via bb841b4 December 17, 2024 16:44

atticusofsparta temporarily deployed to develop December 17, 2024 16:50 — with GitHub Actions Inactive

atticusofsparta added 2 commits December 18, 2024 09:04

fix(reassign): block reassign workflow if name is in grace period

aac7cb8

Merge pull request #631 from ar-io/PE-7323-name-during-grace-period

92fc632

fix(PE-7323): block reassign workflow if name is in grace period

atticusofsparta temporarily deployed to develop December 18, 2024 19:30 — with GitHub Actions Inactive

atticusofsparta merged commit e6feb31 into develop Dec 18, 2024
6 checks passed

atticusofsparta deleted the PE-7068-reassign-name branch December 18, 2024 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(PE-7068): reassign name #624

feat(PE-7068): reassign name #624

atticusofsparta commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024

atticusofsparta Dec 13, 2024

atticusofsparta Dec 13, 2024

fedellen Dec 13, 2024

fedellen Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024

fedellen Dec 13, 2024 •

edited

Loading

atticusofsparta Dec 13, 2024

fedellen Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024

fedellen Dec 13, 2024 •

edited

Loading

atticusofsparta Dec 13, 2024

fedellen left a comment

kunstmusik Dec 16, 2024

feat(PE-7068): reassign name #624

feat(PE-7068): reassign name #624

Conversation

atticusofsparta commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedellen Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedellen Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedellen Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedellen Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedellen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024 •

edited

Loading

fedellen Dec 13, 2024 •

edited

Loading