Update WaveFile.cs #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to allow parsing WAV files which use an Extension chunk to describe PCM audio formats greater than 16-bit. Microsoft states that any WAV file with a Bit Depth of more than 16 should use the Extension chunk to describe it's Audio Format, but it still uses the same Audio Format constants that are used at the container-level Audio Format definition.
Typo. Authored in Web editor == no red squiggles.
ar1st0crat
reviewed
Sep 26, 2022
ar1st0crat
reviewed
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to allow parsing WAV files which use an Extension chunk to describe PCM audio formats greater than 16-bit. Microsoft states that any WAV file with a Bit Depth of more than 16 should use the Extension chunk to describe the Audio Format, but it will still use the same Audio Format constants used in the container-level Audio Format.
When a file uses the Extension chunk to describe a non-custom Audio Format, the container-level Audio Format will be set to
0xFFFE.This is currently not handled by
WaveFile, and at the moment results in no sample data being read.Link to relevant sources included in code comments.