Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for dot-format (e.g. 13.1.2009) with ambiguousMMDD #91

Open
skius opened this issue Aug 24, 2019 · 0 comments · May be fixed by #159
Open

Better support for dot-format (e.g. 13.1.2009) with ambiguousMMDD #91

skius opened this issue Aug 24, 2019 · 0 comments · May be fixed by #159

Comments

@skius
Copy link

skius commented Aug 24, 2019

While the dot format is currently supported for MM.DD.YYYY, this format does not set the ambiguousMMDD flag. This leads to issues mainly in fixes for #28 (such as #89), where ambiguousMMDD needs to be set.

The way I see it, ambiguousMMDD needs to be set for all ambiguous date formats (regardless the separator).

(FWIW, I'm pretty sure the dot separator is mostly used in DD.MM.YY[YY] formats anyway.)
@skius skius changed the title Better support for dot-format (e.g. 12.1.2009) with ambiguousMMDD Better support for dot-format (e.g. 13.1.2009) with ambiguousMMDD Aug 25, 2019
@krisavi krisavi mentioned this issue Jul 15, 2021
Open
klondikedragon added a commit to itlightning/dateparse that referenced this issue Dec 13, 2023
@klondikedragon
Add tests to verify ambiguous cases
8f0059d 
Test cases now validates the following is true:
* Fixed araddon#91
* Fixed araddon#28

(previous commits already addresses these issues, these tests ensure
that these issues remain fixed)
@klondikedragon klondikedragon linked a pull request Dec 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@skius