Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expression Inliner for includes #182

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Add Expression Inliner for includes #182

merged 2 commits into from
Aug 23, 2017

Conversation

araddon
Copy link
Owner

@araddon araddon commented Aug 23, 2017

closes #181 allow nested expressions that are referenced by the INCLUDE statement to be inlined for easier reading.

@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #182 into master will increase coverage by 0.24%.
The diff coverage is 64.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   39.89%   40.14%   +0.24%     
==========================================
  Files          83       84       +1     
  Lines       24956    25007      +51     
==========================================
+ Hits         9956    10038      +82     
+ Misses      13268    13233      -35     
- Partials     1732     1736       +4
Impacted Files Coverage Δ
rel/parse_filterql.go 57.69% <ø> (ø) ⬆️
expr/node.go 45.56% <33.33%> (+1.5%) ⬆️
expr/include.go 74.35% <74.35%> (ø)
expr/stringutil.go 79.54% <0%> (+3.03%) ⬆️
expr/parse.go 60.6% <0%> (+3.18%) ⬆️
expr/funcs.go 52.63% <0%> (+21.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253bf47...e8f69bf. Read the comment docs.

@araddon araddon merged commit 85ef97a into master Aug 23, 2017
@araddon araddon deleted the 181_expr_inline branch August 23, 2017 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Statement Inliner
2 participants