-
Notifications
You must be signed in to change notification settings - Fork 27
Add support for Service SAS #60
Comments
Trying to be helpful, I've started work on this already on my fork (as well as issue #59). I was going to create a PR after I updated the tests (I wrote some tests against the emulator as part of another project and then made this match those tests). However, I've noticed that there are inconsistencies between the Java and Node SDK's and then there are also differences to the documentation as well. If you want, I can create a PR into a branch and you can continue on that if you wish (I'm sure you can write it in a nicer way than I have). Edit: I may have actually got it sorted. |
@gigaSproule This is great! Really appreciate your efforts here. Really excited to see your PR once you're done. :-) |
@gigaSproule How far did you already get? I am asking because it is a while since you announced your PR, and I want to make sure that we are not waiting for something already abandoned. |
Hey, I did get something working, but I'm not going to say it's great code... |
Hi everybody, |
@arafato As I said before, the code isn't pretty as I never got round to cleaning it up or dealing with every edge case. However, it should be a good starting point. Just so you are aware, to figure out the correct behaviour, I had the azure storage emulator running and used it's responses as a guide for the behaviour. |
@gigaSproule @thisisthekap just published support for service-level SAS as v1.7.0. Hope you like it :-) |
Thanks you very much for your effort. Nevertheless, I think some parts are not working flawlessly. I just created #124 to track the issue I experienced. |
Good work guys. Sorry I wasn't able to get any further than I did. @thisisthekap unfortunately, I can see this being a never ending issue unless Microsoft finally provide an official alternative to this :( |
@gigaSproule I think it works now for most of the scenarios. The problem is when you are using Microsoft's SDKs to generate the signature. You can't really specify the version to use. Depending on the SDK version it will use different versions and you can't override. See Azure/azure-storage-node#382 for details. This is why in Azurite we are now generating the signature by ourselves to be able to specify the exact version. |
See https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas for specification.
The text was updated successfully, but these errors were encountered: