Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass custom activation function in policy_kwargs #41

Merged
merged 10 commits into from
Apr 3, 2024

Conversation

paolodelia99
Copy link
Contributor

@paolodelia99 paolodelia99 commented Apr 2, 2024

Added the possibility to pass a custom activation function through the policy_kwargs argument when creating the following models: TD3, SAC, DDPG and DQN (like in sablebaseline3).

Description

Taking inspiration from stablebaseline, I've put the common code of the critic under the sbx\common\policy.py file since the critic code both in the sac module and in td3 module was the same.

Minor changes to .gitignore and Makefile have been made.

Motivation and Context

closes #37

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

.gitignore Outdated Show resolved Hide resolved
tests/test_run.py Outdated Show resolved Hide resolved
tests/test_run.py Outdated Show resolved Hide resolved
sbx/sac/policies.py Outdated Show resolved Hide resolved
Copy link
Owner

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for the PR =)

quick question: why not PPO too?

@araffin araffin changed the title Able to pass flax activation function in policy_kwargs Allow to pass custom activation function in policy_kwargs Apr 2, 2024
@paolodelia99
Copy link
Contributor Author

quick question: why not PPO too?

You can already pass the activation function in PPO, I just kept things like in stablebaseline3.

Copy link
Owner

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit 655f4a3 into araffin:master Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Passing custom activation functon in policy_kwargs
2 participants