-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass custom activation function in policy_kwargs
#41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks for the PR =)
quick question: why not PPO too?
policy_kwargs
You can already pass the activation function in PPO, I just kept things like in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks =)
Added the possibility to pass a custom activation function through the
policy_kwargs
argument when creating the following models:TD3
,SAC
,DDPG
andDQN
(like in sablebaseline3).Description
Taking inspiration from
stablebaseline
, I've put the common code of the critic under thesbx\common\policy.py
file since the critic code both in thesac
module and intd3
module was the same.Minor changes to
.gitignore
andMakefile
have been made.Motivation and Context
closes #37
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line