Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Auto option for detecting both motors with a higher strength #38

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

onenowy
Copy link
Contributor

@onenowy onenowy commented Apr 8, 2023

Both option can also dectect both motors, but it takes less strength than Left or Right option sometimes.

"Both" option can also dectect both motors, but it takes less strength than "Left" or "Right" option sometimes.
@araghon007
Copy link
Owner

Hey, sorry to keep you hanging. I might possibly merge this, but ultimately I'll need a way better system of handling these.
I also don't quite understand what you mean by it taking less strength than the other options.

@onenowy
Copy link
Contributor Author

onenowy commented Apr 12, 2023

Sorry for my english. I mean when I set Left or RightTriggerLink to Both, trigger strength is weaker than when set TriggerLink to Left or Right. So I added Auto to copy higher strength from both motors to trigger motor.

@araghon007
Copy link
Owner

Ah, I see. That's fair enough, although I believe even that lower strength can be too strong sometimes.

@araghon007 araghon007 merged commit 606ff5e into araghon007:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants