Detect if IPFS is initialized in a more robust way, to resolve #744

[dapplion]

🦅 Pull Request

Detect if IPFS is initialized in a more robust way, by calling

ipfs config show

which exits with 1 if IPFS is not initialized and with 0 if it is.

Fixes #744

🚨 Test instructions

Install IPFS using SNAP
Run aragon ipfs

The current version produces this output

  ⠼ Start IPFS
    → Starting IPFS at port: 5001
    Add local files
(node:16693) UnhandledPromiseRejectionWarning: Error: Command failed: /snap/bin/ipfs init
Error: ipfs configuration file already exists!
Reinitializing would overwrite your keys.


initializing IPFS node at /home/lion/snap/ipfs/1170/.ipfs

    at makeError (/home/lion/aragon-cli/packages/aragon-cli/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/home/lion/aragon-cli/packages/aragon-cli/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:16693) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside   ✖ Start IPFS
    → Starting IPFS timed out:
    Add local files
✖ Starting IPFS timed out:

and with this PR

  ✔ Start IPFS
  ✔ Add local files
ℹ IPFS daemon is now running. Stopping this process will stop IPFS

✔️ PR Todo

• Include links to related issues/PRs
• Update unit tests for this change
• Update the relevant documentation
• Clear dependencies on other modules that have to be released before merging this

[dapplion]

Also, the go-ipfs team recommends to test if the IPFS daemon is running by checking the swarm addresses ipfs/kubo#5983. I believe running

ipfs swarm addrs

would be better and simpler than the current strategy:

• checking if the IPFS port is busy, and
• calling the API at the /id endpoint

@0xGabi Let me know if this change would be of interest

[0xGabi]

@dapplion seems like a nice to have feature right now. Would like to know what other think about it, @macor161 @0x6431346e

[macor161]

Yes I think it's an improvement from what we had before. Thanks @dapplion !
I will test it to make sure everything works.

[macor161]

@dapplion await execa(ipfsBin, ['config', 'show']) seems to always fail on my laptop (Mac). So it always try to initialize even when it is already initialized. Would you know why?

Until the problem is resolved, I propose we postpone this PR.

[dapplion]

@dapplion await execa(ipfsBin, ['config', 'show']) seems to always fail on my laptop (Mac). So it always try to initialize even when it is already initialized. Would you know why?

Until the problem is resolved, I propose we postpone this PR.

Could you provide the logs / error output when attempting to run it? What OS do you have?

Also, does running directly on a terminal ipfs config show produce a different outcome? If so please paste the output

[macor161]

@dapplion :

{ Error: Command failed: /Users/mathew/.nvm/versions/node/v10.16.0/bin/ipfs config show
Error: api not running


    at makeError (/Users/mathew/workspace/aragon-forks/aragon-cli/packages/aragon-cli/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/Users/mathew/workspace/aragon-forks/aragon-cli/packages/aragon-cli/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)

[0xGabi]

@0x6431346e what do you think of including this change on the 2nd iteration?

[dapplion]

I want to add that aragon ipfs start never works on my linux.

lion@lion:~/$ aragon ipfs start
  ⠇ Start IPFS
    → Starting IPFS at port: 5001
    Add local files
(node:17349) UnhandledPromiseRejectionWarning: Error: Command failed: /snap/bin/ipfs init
Error: ipfs configuration file already exists!
Reinitializing would overwrite your keys.


initializing IPFS node at /home/lion/snap/ipfs/1170/.ipfs

    at makeError (/home/lion/.nvm/versions/node/v10.15.3/lib/node_modules/@aragon/cli/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/home/lion/.nvm/versions/node/v10.15.3/lib/node_modules/@aragon/cli/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:17349) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (reje  ✖ Start IPFS
    → Starting IPFS timed out:
    Add local files
✖ Starting IPFS timed out:

[dapplion]

I would advise to switch to https://github.com/ipfs/js-ipfsd-ctl instead of handling the daemon ourselves with execa calls.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

[0xGabi]

We will not pursue this new feature improvement.