-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required solidity version #158
Comments
Hmm, I'm not a huge fan of this idea. Pinning solidity versions is usually a security recommendation, because you never know what might be wrong with a new We could manually update the version as new
Are we? AFAIK app developers are free to use whatever version they want. If there's a problem with interfaces that we provide, then we should separate those out into different files and only apply loose versions on them. |
That’s a good point actually. Strict versions on core logic and loose
versions on interfaces.
…On Mon, 4 Dec 2017 at 22:06, Brett Sun ***@***.***> wrote:
Hmm, I'm not a huge fan of this idea. Pinning solidity versions is usually
a security recommendation, because you never know what might be wrong with
a new solc.
We could manually update the version as new solc versions are released,
after at least running the tests.
------------------------------
we are forcing all app developers to use the same solidity version
Are we? AFAIK app developers are free to use whatever version they want.
If there's a problem with interfaces that we provide, then we should
separate those out into different files and only apply loose versions on
them.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#158 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbTYF3qqlFPCkh5U-79E_Px27ru03fnks5s9F64gaJpZM4Qzt50>
.
|
By requiring a fixed solidity version in all
aragon-core
files, we are forcing all app developers to use the same solidity version, which right now is set to0.4.15
.At least we should allow
0.4
versions greater than15
by changing it to^0.4.15
.The text was updated successfully, but these errors were encountered: