Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required solidity version #158

Closed
izqui opened this issue Dec 3, 2017 · 2 comments · Fixed by #169
Closed

Required solidity version #158

izqui opened this issue Dec 3, 2017 · 2 comments · Fixed by #169

Comments

@izqui
Copy link
Contributor

izqui commented Dec 3, 2017

By requiring a fixed solidity version in all aragon-core files, we are forcing all app developers to use the same solidity version, which right now is set to 0.4.15.

At least we should allow 0.4 versions greater than 15 by changing it to ^0.4.15.

@sohkai
Copy link
Contributor

sohkai commented Dec 4, 2017

Hmm, I'm not a huge fan of this idea. Pinning solidity versions is usually a security recommendation, because you never know what might be wrong with a new solc.

We could manually update the version as new solc versions are released, after at least running the tests.


we are forcing all app developers to use the same solidity version

Are we? AFAIK app developers are free to use whatever version they want. If there's a problem with interfaces that we provide, then we should separate those out into different files and only apply loose versions on them.

@izqui
Copy link
Contributor Author

izqui commented Dec 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants