Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runs inconsistent? #237

Closed
verdverm opened this issue Feb 23, 2018 · 3 comments
Closed

Test runs inconsistent? #237

verdverm opened this issue Feb 23, 2018 · 3 comments

Comments

@verdverm
Copy link
Contributor

verdverm commented Feb 23, 2018

I think I've been seeing issues in the test environment, both locally and on travis. (see builds for #235 #236)

  • npm test fails and then passes on a second attempt.
  • npm test passes and npm run coverage fails

Is this a known issue? Any thoughts on the causes?

(I see test and coverage use different networks and binaries for the test network)

Maybe the difference between test and coverage is also due to branches? I've noticed that coverage is not picking up the changed files. (See 235 on travis)

@sohkai
Copy link
Contributor

sohkai commented Feb 23, 2018

The coverage failure in #236 seems to be a sol-cover issue; it seems to not be using a .call() on that test.

What does npm test fail on?

@verdverm
Copy link
Contributor Author

I think the KernelUpgrade section? I'll make note to give a more certain response next time I see it.

@sohkai
Copy link
Contributor

sohkai commented May 8, 2018

Closing, since this seems to not be reproducible. Our testing set up has also changed significantly since this was issued.

Please open again if it's consistent :).

@sohkai sohkai closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants