cleans up a number of visibility warnings #235
Conversation
| @@ -36,7 +36,7 @@ contract EVMScriptRunner is AppStorage, EVMScriptRegistryConstants { | |||
| /** | |||
| * @dev copies and returns last's call data. Needs to ABI decode first | |||
| */ | |||
| function returnedDataDecoded() internal view returns (bytes ret) { | |||
| function returnedDataDecoded() internal pure returns (bytes ret) { | |||
There was a problem hiding this comment.
I'm not 100% sure, but I think this should be a view function since it's relying on manipulating memory. Correct me if I'm wrong though; my understanding was that pure is for functions that only use their params.
There was a problem hiding this comment.
Note to self: clearly I was wrong. view is only necessary for SLOAD and SSTORE.
| @@ -51,7 +51,7 @@ contract DelegateScript is IEVMScriptExecutor { | |||
| /** | |||
| * @dev copies and returns last's call data | |||
| */ | |||
| function returnedData() internal view returns (bytes ret) { | |||
| function returnedData() internal pure returns (bytes ret) { | |||
.travis.yml
Outdated
| @@ -8,6 +8,7 @@ node_js: | |||
| - '8' | |||
| env: | |||
| - TASK=lint | |||
| - TASK=test | |||
There was a problem hiding this comment.
Why has this been added in this PR? Until we merge #186, running the test suite isn't relevant, as if some test fails, coverage will error.
|
So it turns out we can't really use Some of the previous changes still pass, since we're only using them with |
No description provided.