Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin ganache-cli to 6.2.3 #472

Merged
merged 1 commit into from
Feb 7, 2019
Merged

chore: pin ganache-cli to 6.2.3 #472

merged 1 commit into from
Feb 7, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jan 20, 2019

Check with the CI that ganache-cli@6.2.3 and ganache-core@2.3.1 are not breaking our tests.

@sohkai sohkai added the blocked label Jan 20, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.762% when pulling 1c52823 on pin-ganache-6.2.3 into da862e2 on dev.

@sohkai sohkai mentioned this pull request Jan 20, 2019
Closed
@sohkai sohkai changed the title [DO NOT MERGE] chore: pin ganache-cli to 6.2.3 chore: pin ganache-cli to 6.2.3 Feb 7, 2019
@sohkai sohkai removed the blocked label Feb 7, 2019
@sohkai
Copy link
Contributor Author

sohkai commented Feb 7, 2019

Will merge this for now since ganache-cli@6.4.0 is still having testing problems (see trufflesuite/ganache#283).

@sohkai sohkai merged commit c4e0fb1 into dev Feb 7, 2019
@sohkai sohkai deleted the pin-ganache-6.2.3 branch February 7, 2019 16:03
sohkai added a commit that referenced this pull request Mar 8, 2019
@sohkai
chore: pin ganache-cli to 6.2.3 (#472)
2247847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sohkai @coveralls