Meta Txs: Adding support for meta transactions in aragon apps (Part 2) #527
Conversation
| @@ -37,7 +37,7 @@ | |||
| "eth-ens-namehash": "^2.0.8", | |||
| "eth-gas-reporter": "^0.1.1", | |||
| "ethereumjs-abi": "^0.6.5", | |||
| "ganache-cli": "^6.4.2", | |||
| "ganache-cli": "~6.2.0", | |||
There was a problem hiding this comment.
Interesting, was the latest version failing due to the gas estimation?
There was a problem hiding this comment.
Exactly, I was facing this issue
|
|
||
| async _fetchMainnetGasPrice() { | ||
| try { | ||
| const axios = require('axios') |
There was a problem hiding this comment.
Might as well lift this up as a top-level import
| ], | ||
| } | ||
|
|
||
| module.exports = web3 => class RelayTransactionSigner { |
There was a problem hiding this comment.
What do you think about either placing the web3 instance inside these classes, or extracting the web3 instance used into its own util (e.g. getWeb3()).
Generally we don't run services in the context of a truffle environment (maybe we should? I'm a bit scared at needing to depend on them for the service to stay alive), so there's no global web3 instance available.
It'd also avoid defining a class in a function, which is a bit awkward, since you can have different definitions if you invoke the function more than once. This then starts to violate the instanceof checks and prototype chains, and gets very awkward if you ever need to compare / manipulate more than one object derived from what should be same class.
There was a problem hiding this comment.
Completely agree, it should be part of the constructor o at least a known object that resolves that dependency
facuspagnuolo
force-pushed
the
meta-txs-service
branch
from
787bef9 to
7206c7e
Compare
facuspagnuolo
force-pushed
the
meta-txs-service
branch
from
7206c7e to
4344738
Compare
Following up #526
This PR aims to provide the required JS libraries to implement an meta-transactions server that will act as the off-chain part of the relayer for the model described in the previous PR.
We will probably want to move this logic outside of aragonOS. Once we have the relayer server repo, I think it will fit better there.