Disputable: Support payable actions #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Jul 15, 2020
| @@ -129,7 +129,7 @@ contract DisputableAragonApp is IDisputable, AragonApp { | |||
| */ | |||
| function _newAgreementAction(uint256 _disputableActionId, bytes _context, address _submitter) internal returns (uint256) { | |||
| IAgreement agreement = _ensureAgreement(); | |||
| return agreement.newAction(_disputableActionId, _context, _submitter); | |||
| return agreement.newAction.value(msg.value)(_disputableActionId, _context, _submitter); | |||
There was a problem hiding this comment.
I wonder if we shouldn't expose this as a parameter instead; maybe the app takes a cut of ETH itself or etc.
There was a problem hiding this comment.
If the app manipulates it, the agreement app won't be able to pay fees, unless the user is sending more than the required amount. However, how would a parameter help here?
There was a problem hiding this comment.
Yes, I was imagining the user sending more fees to the app (because of app-specific logic).
As an example, in the case of a registry, maybe you need to stake some additional ETH into the app as well as pay the fee.
The parameter would help here because the app then has control over how much value is sent.
Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>
bingen
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.