Skip to content

Commit

Permalink
Update the Aragon OSx docs by commit 1b4d80a
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael-A-Heuer authored and arabot-1 committed Feb 9, 2024
1 parent 5053a64 commit 9a5a4e4
Show file tree
Hide file tree
Showing 46 changed files with 9 additions and 3,794 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Setting this permission is key because it ensures only signers who have been gra

Now that we have created the permission, we will use it to protect the implementation. We want to make sure only the authorized callers holding the `ADMIN_EXECUTE_PERMISSION`, can use the function.

Because we have initialized the [`PluginClonable` base contract](../../../03-reference-guide/core/plugin/PluginCloneable.md), we can now use its features, i.e., the [`auth` modifier](../../../03-reference-guide/core/plugin/dao-authorizable/DaoAuthorizable.md#internal-modifier-auth) provided through the `DaoAuthorizable` base class. The `auth('ADMIN_EXECUTE_PERMISSION')` returns an error if the address calling on the function has not been granted that permission, effectively protecting from malicious use cases.
Because we have initialized the [`PluginClonable` base contract](https://github.com/aragon/osx-commons/blob/develop/contracts/src/plugin/PluginCloneable.sol), we can now use its features, i.e., the [`auth` modifier](https://github.com/aragon/osx-commons/blob/1cf46ff15dbda8481f9ee37558e7ea8b257d51f2/contracts/src/permission/auth/DaoAuthorizable.sol#L30-L35) provided through the `DaoAuthorizable` base class. The `auth('ADMIN_EXECUTE_PERMISSION')` returns an error if the address calling on the function has not been granted that permission, effectively protecting from malicious use cases.

Later, we will also use the [`dao()` getter function from the base contract](../../../03-reference-guide/core/plugin/dao-authorizable/DaoAuthorizable.md#public-function-dao), which returns the associated DAO for that plugin.
Later, we will also use the [`dao()` getter function from the base contract](https://github.com/aragon/osx-commons/blob/1cf46ff15dbda8481f9ee37558e7ea8b257d51f2/contracts/src/permission/auth/DaoAuthorizable.sol#L24-L28), which returns the associated DAO for that plugin.

```solidity
contract SimpleAdmin is PluginCloneable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ To publish new versions in the future,

## Conclusion

Hope this tutorial is useful to get you started developing for Aragon! If you need any additional support or questions, feel free to hop into our [Discord](https://discord.gg/Wpk36QRdMN) and ask away.
Hope this tutorial is useful to get you started developing for Aragon! If you need any additional support or questions, feel free to hop into our [Discord](https://discord.com/channels/672466989217873929/742442842474938478) and ask away.

Excited to see what you build! 🔥

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,10 @@ You may want to have a publishing script directly off of your Hardhat project. I
```js
import buildMetadata1 from '../../contracts/release1/build1/build-metadata.json';
import releaseMetadata1 from '../../contracts/release1/release-metadata.json';
import {
networkNameMapping,
osxContracts,
findEventTopicLog,
addDeployedContract,
} from '../../utils/helpers';
import {networkNameMapping, osxContracts, addDeployedContract} from '../../utils/helpers';
import {toHex} from '../../utils/ipfs-upload';
import {uploadToIPFS} from '../../utils/ipfs-upload';
import {findEventTopicLog} from '@aragon/osx-commons-sdk';
import {
PluginRepoFactory__factory,
PluginRepoRegistry__factory,
Expand Down Expand Up @@ -116,9 +112,6 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
PluginRepoRegistry__factory.createInterface(),
'PluginRepoRegistered'
);
if (!eventLog) {
throw new Error('Failed to get PluginRepoRegistered event log');
}

const pluginRepo = PluginRepo__factory.connect(eventLog.args.pluginRepo, deployer);

Expand Down
227 changes: 0 additions & 227 deletions docs/osx/03-reference-guide/core/dao/IDAO.md

This file was deleted.

This file was deleted.

21 changes: 0 additions & 21 deletions docs/osx/03-reference-guide/core/permission/PermissionCondition.md

This file was deleted.

This file was deleted.

47 changes: 0 additions & 47 deletions docs/osx/03-reference-guide/core/permission/PermissionLib.md

This file was deleted.

Loading

0 comments on commit 9a5a4e4

Please sign in to comment.