feat(APP-3746): Update ProposalDataListItem component to support "advanceable" status #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekidnamedkd
changed the title
cgero-eth
reviewed
Jan 13, 2025
...proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.test.tsx
Outdated
Show resolved
Hide resolved
...ents/proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.tsx
Show resolved
Hide resolved
...osal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.api.ts
Show resolved
Hide resolved
src/modules/components/proposal/proposalDataListItem/proposalDataListItemUtils.ts
Outdated
Show resolved
Hide resolved
cgero-eth
changed the title
cgero-eth
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Hey @thekidnamedkd, I see some things that are not aligned with design and requirement, could you double check your PR and all the changes you introduced?
...osal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.api.ts
Show resolved
Hide resolved
src/modules/components/proposal/proposalDataListItem/proposalDataListItemUtils.ts
Outdated
Show resolved
Hide resolved
thekidnamedkd
commented
Jan 14, 2025
cgero-eth
reviewed
Jan 15, 2025
...ents/proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.tsx
Outdated
Show resolved
Hide resolved
...ents/proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.tsx
Outdated
Show resolved
Hide resolved
...ents/proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.tsx
Outdated
Show resolved
Hide resolved
...osal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.api.ts
Show resolved
Hide resolved
...proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.test.tsx
Outdated
Show resolved
Hide resolved
...proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.test.tsx
Outdated
Show resolved
Hide resolved
...proposal/proposalDataListItem/proposalDataListItemStatus/proposalDataListItemStatus.test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds statusContext property and remove implementations for ApprovalThreshold and MajorityVoting subcomponents
Task: APP-3746
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the [UPCOMING] title and before thelatest version.