Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3693): Remove onFileError property from InputFileAvatar and utilise onChange to handle errors #387

Merged
merged 15 commits into from
Jan 15, 2025

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Jan 15, 2025

Description

Remove onFileError property from InputFileAvatar and utilise onChange to handle errors

Task: APP-3693

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the
    latest version.

@shan8851 shan8851 requested a review from cgero-eth January 15, 2025 11:48
@cgero-eth cgero-eth merged commit 003d7c5 into main Jan 15, 2025
4 checks passed
@cgero-eth cgero-eth deleted the feat/app-3693 branch January 15, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants