Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3851): Prevent displacement of placeholder on AddressInput #388

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jan 20, 2025

Description

Adds min-h-11 to address input which keeps interior height of text-area from mounting with style:"height: 0" by default when composed in forms and other components

Task: APP-3851

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the
    latest version.

Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@cgero-eth cgero-eth merged commit 9176a11 into main Jan 20, 2025
4 checks passed
@cgero-eth cgero-eth deleted the fix/APP-3851 branch January 20, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants