chore: sync with osx-plugin-template-hardhat develop branch
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>
…-configs feat: use new osx common network configs
* doc: added missing comment * build: remove redundant dependency * feat: add a function to generate a random ens, set the ens to the plugin settings * feat: bump commons config version in subgraph * feat: add random name function * refactor: settings --------- Co-authored-by: Claudia <claudiabarcelovaldes40@gmail.com>
…-intead-of-commits
…over-pr-intead-of-commits fix: GitHub actions to run over PR changes instead of commit changes
…Plugin address to the json
…ddress is not set
fix: plugin repo address
heueristik
changed the title
osx-plugin-template-hardhat the develop branchosx-plugin-template-hardhat develop branch
jordaniza
approved these changes
Mar 15, 2024
Rekard0
approved these changes
Mar 15, 2024
clauBv23
reviewed
Mar 15, 2024
Comment on lines
+254
to
+264
| export function generateRandomName(length: number): string { | ||
| const allowedCharacters = 'abcdefghijklmnopqrstuvwxyz-0123456789'; | ||
| let result = ''; | ||
| for (let i = 0; i < length; i++) { | ||
| result += allowedCharacters.charAt( | ||
| Math.floor(Math.random() * allowedCharacters.length) | ||
| ); | ||
| } | ||
| return result; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function should not be needed in the multisig, it was used for the template plugin name, but here it is always the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the changes from https://github.com/aragon/osx-plugin-template-hardhat/tree/develop
Task ID: OS-1139