deploy(contracts): corrects managing DAO proposal formatting (#519)

* deploy(contracts): corrects managing DAO proposal formatting

* deploy(contracts): improves upgrade 1.3.0 readability

* deploy(contracts): improves proposal summary text

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

---------

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

packages/contracts/deploy/update/to_v1.3.0/10_DAOFactory.ts

@@ -60,7 +60,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: managingDAOAddress,
     value: 0,
     data: calldata,
-    description: `Moves the REGISTER_DAO_PERMISSION_ID permission on the DAORegistry (${daoRegistryAddress}) from the old to the new DAOFactory (${previousDAOFactoryAddress} -> ${deployResult.address}).`,
+    description: `Moves the <strong>REGISTER_DAO_PERMISSION_ID</strong> permission on the <strong>DAORegistry</strong> (<code>${daoRegistryAddress}</code>) from the old <strong>DAOFactory</strong> (<code>${previousDAOFactoryAddress}</code>) to the new <strong>DAOFactory</strong> (<code>${deployResult.address}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/20_PluginRepoFactory.ts

@@ -60,7 +60,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: managingDAOAddress,
     value: 0,
     data: calldata,
-    description: `Moves the REGISTER_PLUGIN_REPO_PERMISSION permission on the PluginRepoRegistry (${pluginRepoRegistryAddress}) from the old to the new PluginRepoFactory (${previousPluginRepoFactoryAddress} -> ${deployResult.address}).`,
+    description: `Moves the <strong>REGISTER_PLUGIN_REPO_PERMISSION</strong> permission on the <strong>PluginRepoRegistry</strong> (<code>${pluginRepoRegistryAddress}</code>) from the old <strong>PluginRepoFactory</strong> (<code>${previousPluginRepoFactoryAddress}</code>) to the new <strong>PluginRepoFactory</strong> (<code>${deployResult.address}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/30_Multisig_PluginRepo.ts

@@ -40,7 +40,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the "multisig-repo" PluginRepo (${multisigPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
+    description: `Upgrade the <strong>Multisig PluginRepo</strong> (<code>${multisigPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/31_Multisig_Plugin.ts

@@ -79,7 +79,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: tx.to,
     data: tx.data,
     value: 0,
-    description: `Creates a new build for release 1 in the MultisigRepo (${multisigRepoAddress}) with MultisigSetup (${deployResult.address})`,
+    description: `Creates a new build for release 1 in the <strong>Multisig PluginRepo</strong> (<code>${multisigRepoAddress}</code>) with <strong>MultisigSetup</strong> (<code>${deployResult.address}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/40_TokenVoting_PluginRepo.ts

@@ -40,7 +40,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the "token-voting-repo" PluginRepo (${tokenVotingPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
+    description: `Upgrade the <strong>TokenVoting PluginRepo</strong> (<code>${tokenVotingPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/41_TokenVoting_Plugin.ts

@@ -116,7 +116,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: tx.to,
     data: tx.data,
     value: 0,
-    description: `Creates a new build for release 1 in the TokenVotingRepo (${tokenVotingRepoAddress}) with TokenVotingSetup (${deployResult.address})`,
+    description: `Creates a new build for release 1 in the <strong>TokenVoting PluginRepo</strong> (<code>${tokenVotingRepoAddress}</code>) with <strong>TokenVotingSetup</strong> (<code>${deployResult.address}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/50_AddresslistVoting_PluginRepo.ts

@@ -41,7 +41,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the "address-list-voting-repo" (${addresslistVotingPluginRepoAddress}) PluginRepo to the new implementation (${newPluginRepoImplementation})`,
+    description: `Upgrade the <strong>Addresslist PluginRepo</strong> (<code>${addresslistVotingPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/51_AddresslistVoting_Plugin.ts

@@ -84,7 +84,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: tx.to,
     data: tx.data,
     value: 0,
-    description: `Creates a new build for release 1 in the AddresslistVotingRepo (${addresslistVotingRepoAddress}) with AddresslistVotingSetup (${deployResult.address})`,
+    description: `Creates a new build for release 1 in the <strong>AddresslistVoting PluginRepo</strong> (<code>${addresslistVotingRepoAddress}</code>) with <strong>AddresslistVotingSetup</strong> (<code>${deployResult.address}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/60_Admin_PluginRepo.ts

@@ -37,7 +37,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the "admin-repo" PluginRepo (${adminPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
+    description: `Upgrade the <strong>Admin PluginRepo</strong> (<code>${adminPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/update/to_v1.3.0/90_ManagingDAO.ts

@@ -33,7 +33,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the managing DAO to the new implementation (${newDaoImplementation})`,
+    description: `Upgrade the <strong>management DAO</strong> (<code>${managingDAOAddress}</code>) to the new <strong>implementation</strong> (<code>${newDaoImplementation}</code>).`,
   });
 };
 export default func;

packages/contracts/deploy/verification/99_conclude/01_managing_dao_proposal.ts

@@ -23,12 +23,13 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     await managingDAOMultisig.callStatic.multisigSettings();
 
   const proposalDescription = hre.managingDAOActions
-    .map(action => `<p>${action.description}</p>`)
+    .map(action => `<li>${action.description}</li>`)
     .join('');
   const cid = await uploadToIPFS(
     JSON.stringify({
       title: 'Framework Upgrade 1.3.0',
-      summary: proposalDescription,
+      summary: `This proposal upgrades the framework on ${network.name} to version 1.3.0.`,
+      description: `<ul>${proposalDescription}</ul>`,
       resources: [],
     }),
     network.name