Skip to content

Commit

Permalink
Merge pull request #556 from aragon/f/pr-template
Browse files Browse the repository at this point in the history
docs: add a checklist item to PR template && fix broken link
  • Loading branch information
jordaniza authored Mar 25, 2024
2 parents 377ad76 + da250d3 commit 2db7c7c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Description

Please include a summary of the change and be sure you follow the contributions rules we do provide [here](./CONTRIBUTIONS.md)
Please include a summary of the change and be sure you follow the contributions rules we do provide [here](../CONTRIBUTIONS.md)

Task ID: [OS-?](https://aragonassociation.atlassian.net/browse/OS-?)

Expand All @@ -25,3 +25,4 @@ See the framework lifecylce in `packages/contracts/docs/framework-lifecycle` to
- [ ] I have updated the `CHANGELOG.md` file in the root folder.
- [ ] I have updated the `DEPLOYMENT_CHECKLIST` file in the root folder.
- [ ] I have updated the `UPDATE_CHECKLIST` file in the root folder.
- [ ] I have updated the Subgraph and added a QA URL to the description of this PR.
5 changes: 4 additions & 1 deletion CONTRIBUTION_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ If the answer to either of those two questions are "yes", then you're probably d
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I ran all tests with success and extended them if necessary.
[ ] I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
[ ] I have tested my code on the test network.
[ ] I have updated the `CHANGELOG.md` file in the root folder.
[ ] I have updated the `DEPLOYMENT_CHECKLIST` file in the root folder.
[ ] I have updated the `UPDATE_CHECKLIST` file in the root folder.
[ ] I have updated the Subgraph and added a QA URL to the description of this PR.
```

6. Wait for the pull request to be reviewed by the team.
Expand Down

0 comments on commit 2db7c7c

Please sign in to comment.